Add drawio support #158
Merged
Add drawio support #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahirominami
force-pushed
the
add-drawio-support
branch
2 times, most recently
from
691fd20
to
d9040ea
Compare
|
Hello and thanks for your PR. Can you share some files to test this ? |
|
Hi, thank you for the comment. Added test.xml and test.drawio along with the other existing "test.*" files, is this what you expected ? They should be found with keywords like "test-", "test-key", "test-value", "test-success". Draw.io format's sheet names are currently ignored. |
|
Looks good, can you rebase on |
ArtificialOwl
approved these changes
Jun 8, 2022
masahirominami
force-pushed
the
add-drawio-support
branch
from
9118cdc
to
aca8b86
Compare
Signed-off-by: Masahiro Minami <[email protected]>
Signed-off-by: Masahiro Minami <[email protected]>
masahirominami
force-pushed
the
add-drawio-support
branch
from
aca8b86
to
a6a465b
Compare
|
Thanks for checking @ArtificialOwl , rebase done... but I must admit that I am still new to git operation. Hope things didn't get messed up.. |
|
/backport to stable24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to experiment on the issue #21 , and here's my first try.
With this code .xml and .drawio files can be indexed.
If anyone is interested, any feedback will be welcome. Thank you.